Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to the new exp config forms #1251

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Conversation

becky-gilbert
Copy link
Contributor

@becky-gilbert becky-gilbert commented Aug 11, 2023

This PR includes some suggested minor changes to the new separate "Study Ad" and "Study Details" forms (#1244):

  • In studies/templates/studies/experiment_runner/base.html I put the content inside of a div with the row class so that the spacing between the content and breadcrumbs matches that in other pages (studies/templates/studies/study_edit.html, studies/templates/studies/study_create.html).
  • Added a period to the end of a paragraph.
  • In the EFP edit form, I switched the order of the 'protocol structure' and 'protocol generator' fields because the protocol structure is the one that came first before and that most researchers will use (I think).
  • Made the checkbox border darker for the 'Use protocol generator' option, to make it more visible.
  • Modified the link in the EFP commit SHA help text so that the page opens in a new tab.
  • Added the BS5 'fw-bold' class to the form labels on the EFP and External forms, to make them more visible and to match the labels on the study ad form.

Study details - before:

Screenshot 2023-08-11 at 11 12 56 AM

Screenshot 2023-08-11 at 2 53 05 PM

Study details - after changes in this PR:

Screenshot 2023-08-11 at 2 16 00 PM
Screenshot 2023-08-11 at 2 17 33 PM

Study ad (not changed, just for reference):

Screenshot 2023-08-11 at 2 49 13 PM

Also tagging @mekline for review of these changes, since some of my suggestions might contradict her requests.

@becky-gilbert becky-gilbert marked this pull request as ready for review August 11, 2023 21:51
Copy link
Contributor

@bleonar5 bleonar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like sensible formatting changes

@okaycj
Copy link
Contributor

okaycj commented Aug 23, 2023

@becky-gilbert Thanks for the updates. I you want, you can always ask for these changes in the original PR. I never mind making these small changes or at least talking about them. Once I get the other PR into develop, I'll rebase this and get it in as well.

Base automatically changed from exp-config to develop August 28, 2023 14:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@okaycj okaycj merged commit 5c1d942 into develop Aug 28, 2023
5 checks passed
@okaycj okaycj deleted the exp-config-becky-edits branch August 28, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants