Query DSL replacing EligibilityModel workflow #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying out filtrex to parse boolean algebras, which would be a possible addendum to (or replacement for) the simpler require/exclude mechanisms currently in place for characteristics/conditions and languages. Also made some simple language changes.
We can now do AND and OR queries on Bitfields using a special manager that I have created, with two methods: has_one_of and has_all_of.
This is a work in progress - remaining todos include: 1) Integrating with view logic 2) Redesigning eligibility view 3) Further specifying grammar to handle gender specifications more naturally, as well as better handling of gestational age.
Here we are, wired up all the way through the frontend! TODO: 1) deprecate WIP eligibility view. I'm sure we'll be able to find a use for some of that code later :) 2) Modify docs to house query DSL and provide a link inline with the study edit and create forms.
In Study Edit and Study Create forms.
These should be bulked up a bit - in particular the complex condition.
Compound OR and AND expressions allowed. Tests included.
|
I see we're checking the criteria string to check that the form is as expected (so that I get e.g. For instance I can currently set eligibility to |
kimberscott
reviewed
Aug 8, 2019
kimberscott
reviewed
Aug 8, 2019
kimberscott
requested changes
Aug 8, 2019
Much more strict.
|
Docs link for criteria expression - https://lookit.readthedocs.io/en/develop/researchers-set-study-fields.html#criteria-expression |
kimberscott
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, fixes #141