Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Double-quotes in query from Query Builder scope causing Postgres error #16

Closed
ccwittwer opened this issue Mar 4, 2016 · 1 comment
Closed

Double-quotes in query from Query Builder scope causing Postgres error #16

ccwittwer opened this issue Mar 4, 2016 · 1 comment

Comments

@ccwittwer
Copy link

when getConditionStringFromQueryBuilder builds $theQuery (line 253), it's using double-quotes, which Postgres sees as a system identifier.

so where "type" = "internal" throws an error saying that the column "internal" does not exist.
changing it to single-quotes, as in where "type" = 'internal', fixes the issue

Potential solution for Postgres queries:

LINE 253:

$theQuery .= '\'' . $bindings[$i] . '\'';
stevendesu added a commit to stevendesu/listify that referenced this issue Dec 15, 2016
@stevendesu
Addresses Issue lookitsatravis#16
f976687 
Skimmed the code and didn't see any additional areas that needed to be updated. Fixed per @ccwittwer's comments. Note that this should also fix MSSQL
lookitsatravis added a commit that referenced this issue Dec 16, 2016
@lookitsatravis
Merge pull request #19 from stevendesu/master
59bbf99 
Addresses Issue #16
@lookitsatravis
Copy link
Owner

Closed with #19 (thanks to @stevendesu)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lookitsatravis @ccwittwer