Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pop-up windows #6

Closed
pdrreid opened this issue Sep 9, 2014 · 10 comments
Closed

enable pop-up windows #6

pdrreid opened this issue Sep 9, 2014 · 10 comments

Comments

@pdrreid
Copy link

pdrreid commented Sep 9, 2014

Is there any way to allow dialogue boxes and popups?

The site I'm trying to kiosk has a couple of buttons that bring up dialogues / pop-ups like 'Are you sure you wish to cancel?', and these are currently disabled.

@matt-cook
Copy link
Member

Looks like this could be done via the manifest: https://developer.chrome.com/extensions/contentSettings#property-popups we'll try and get it pushed into our next version.

@leoherzog
Copy link

Any movement on this? Pages with a "Sign In with Google" button won't work because the pop-up doesn't pop-up. I tried adding "contentSettings.popups", to the manifest, but no luck.

@matt-cook
Copy link
Member

@xd1936 Not yet. It hasn't been an issue on any of our billable projects so it keeps getting bumped down in the queue.

@leoherzog
Copy link

What is an overview of the changes that would need to be made? Is it just a manifest thing?

@matt-cook
Copy link
Member

The manifest update suggestion above is probably not applicable. Likely it would need to be handled by an event listener, as suggested here: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-apps/zzGLSiyWCnM/dMBcPBW2BUcJ

similar to how we handle permission requests for webcam/mic: https://github.com/zebradog/kiosk/blob/master/src/js/browser.js#L159

@matt-cook matt-cook changed the title dialogue boxes and pop-ups - enable? enable pop-ups, dialog, new tab, etc. Oct 7, 2015
@matt-cook matt-cook changed the title enable pop-ups, dialog, new tab, etc. enable pop-up windows Mar 30, 2016
@matt-cook
Copy link
Member

New branch has been created with initial work on pop-up windows: https://github.com/zebradog/kiosk/tree/popup

These can be fairly complex, so likely we'll add support for simple dialogs prior to new windows or tabs: #52

@leoherzog
Copy link

@matt-cook This is great news! All I need is support for Google sign-in buttons, which cause a pop-up window to open and ask the user to log-in.

@leoherzog
Copy link

leoherzog commented May 13, 2016

I checked out the popups branch and tested it out, and Google sign-in buttons launch the sign-in screen perfectly, in full screen. After the user logs in, however, the pop-up does not go away and close itself, leaving the user with a blank full-screen window.

@matt-cook
Copy link
Member

@xd1936 does the latest version 5.8.0 work for you? I've added support for new windows.

@matt-cook
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants