-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable pop-up windows #6
Comments
Looks like this could be done via the manifest: https://developer.chrome.com/extensions/contentSettings#property-popups we'll try and get it pushed into our next version. |
Any movement on this? Pages with a "Sign In with Google" button won't work because the pop-up doesn't pop-up. I tried adding |
@xd1936 Not yet. It hasn't been an issue on any of our billable projects so it keeps getting bumped down in the queue. |
What is an overview of the changes that would need to be made? Is it just a manifest thing? |
The manifest update suggestion above is probably not applicable. Likely it would need to be handled by an event listener, as suggested here: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-apps/zzGLSiyWCnM/dMBcPBW2BUcJ similar to how we handle permission requests for webcam/mic: https://github.com/zebradog/kiosk/blob/master/src/js/browser.js#L159 |
New branch has been created with initial work on pop-up windows: https://github.com/zebradog/kiosk/tree/popup These can be fairly complex, so likely we'll add support for simple dialogs prior to new windows or tabs: #52 |
@matt-cook This is great news! All I need is support for Google sign-in buttons, which cause a pop-up window to open and ask the user to log-in. |
I checked out the |
@xd1936 does the latest version 5.8.0 work for you? I've added support for new windows. |
This issue was moved to https://discuss.kiosk.cook.company/t/enable-pop-up-windows/149 |
Is there any way to allow dialogue boxes and popups?
The site I'm trying to kiosk has a couple of buttons that bring up dialogues / pop-ups like 'Are you sure you wish to cancel?', and these are currently disabled.
The text was updated successfully, but these errors were encountered: