This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
Support class constants for services' names #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example : `Foo::class`
|
I have some code style issues + a nullable return type to remove |
|
Thank you, I'll have a look at it later today. Meanwhile, please check out the failing Travis build. EDIT: You were 3 seconds faster. :) |
hectorj
commented
Jul 18, 2017
| * @param mixed $node | ||
| * @return null|string | ||
| */ | ||
| public static function getServiceIdFromNode($node) |
There was a problem hiding this comment.
I'm not a fan of having this here... but I needed a way to get the ID there : https://github.com/hectorj/phpstan-symfony/blob/ba8dc8d950a5da6117172f1e231fe55b75f34715/src/Rules/ContainerInterfaceUnknownServiceRule.php#L38
I'm open to suggestions.
Don't hesitate to edit the PR if you want to refactor.
|
I'm going to pick this up again and get it implemented. Sorry I was MIA.. |
|
Implemented as 57f8fcb. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
With the newest versions of Symfony, it has become a common practice to use fully qualified class names as services' ids.
So I added support for using class constants like
Foo::classas argument toget()