Fix null errors

Managed to come up with a fix for the null errors, inspired from the comment by [@Mc-muffin](residentsummer#22 (comment)). All chats including group chats transferred over intact, however group chats with members who quit have blank senders. Fixes residentsummer#22
loongyh · Feb 15, 2020 · b7da28f · b7da28f
1 parent 177d05b
commit b7da28f
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/watoi/main.m b/watoi/main.m
@@ -254,7 +254,11 @@ - (NSManagedObject *) addMissingMember:(NSString *)memberJID toChat:(NSString *)
     NSMutableDictionary * members = [self.chatMembers objectForKey:chatJID];
     NSManagedObject *chat = [self.chats objectForKey:chatJID];
 
-    [member setValue:memberJID forKey:@"memberJID"];
+    if (![memberJID isKindOfClass:[NSNull class]]) {
+        [member setValue:memberJID forKey:@"memberJID"];
+    } else {
+        [member setValue:@"null" forKey:@"memberJID"];
+    }
     if (![isAdmin isKindOfClass:[NSNull class]]) {
         [member setValue:isAdmin forKey:@"isAdmin"];
     }
@@ -458,10 +462,6 @@ - (void) importMessages {
                 if (isGroup) {
                     NSString *senderJID = [amsg objectForKey:@"remote_resource"];
                     NSManagedObject *member = [members objectForKey:senderJID];
-                    if (member == nil) {
-                        NSLog(@"\tmissing sender %@", senderJID);
-                        member = [self addMissingMember:senderJID toChat:chatJID asAdmin:@NO];
-                    }
 
                     [msg setValue:member forKey:@"groupMember"];
                 }
@@ -521,6 +521,7 @@ - (void) importMessages {
                 [msg setValue:text forKey:@"text"];
             } else {
                 NSLog(@"null text detected: %@", amsg);
+                [msg setValue:@"<null>" forKey:@"text"];
             }
 
             [msg setValue:chat forKey:@"chatSession"];