Rename GUI commands to follow FreeCAD format #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this change will enable users to use `What's this?` command on FCGear commands and get the correct Wiki article. Fix looooo#151
|
Can we change the workbench name to freecad.gears, maybe doing this also for the wiki. |
|
I think it's doable, but just admins can do it. |
|
is this backward compatible? |
|
I made some test files before the renaming and opening them after the change seems to not affect them. As long as no properties are modified it's safe renaming commands. Even for scripting the |
Closed
|
I have just made this same changes for Fasteners WB and all seems to work fine there also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this?command on FCGear commands and get the correct Wiki article opened.I make the test saving a file prior the change and opening after it, no problems, anyway someone test it. Since no changes on the names of classes that create the objects were made I think is safe to merge.
Fix #151, #154