Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testflight build expiration #269

Merged
merged 5 commits into from Mar 25, 2024
Merged

Testflight build expiration #269

merged 5 commits into from Mar 25, 2024

Conversation

bjorkert
Copy link
Contributor

Enhance Build Information Management

Overview

This PR introduces enhancements to how the app manages and utilizes build information, with a particular focus on distinguishing between Xcode and TestFlight builds. A key part of this enhancement is the inclusion of a manually added BuildDetails.plist file in the project, which stores essential build details. The PR also includes updates to the app's logic to read from this plist and calculate build expiration dates, especially for TestFlight builds, where a specific validity period is important for managing updates and functionality.

Changes

  • Manually Added BuildDetails.plist: BuildDetails.plist has been manually added to the project. It should be updated as needed to reflect current build details.
  • Build Expiration Logic: The SettingsViewController now includes updated logic to read build details from BuildDetails.plist and determine the build's expiration date. This is particularly critical for TestFlight builds, which have a 90-day validity period from the build date.
  • Utility Functions: New utility functions isTestFlightBuild(), buildDate(), and calculateExpirationDate() have been introduced in SettingsViewController to facilitate these enhancements.

Testing

  • Test the app's ability to correctly identify TestFlight builds and calculate expiration dates based on the 90-day validity period.
  • Test the app's ability to correctly identify Mac Xcode builds and show expiration dates based provisioning profile.
  • Confirm that the addition of BuildDetails.plist and the new logic in SettingsViewController do not adversely affect existing app functionality.

Notes

  • The 90-day expiration assumption for TestFlight builds aligns with Apple's guidelines but may require updates if those guidelines change.

@bjorkert bjorkert changed the base branch from main to dev March 25, 2024 13:42
@bjorkert bjorkert marked this pull request as draft March 25, 2024 13:43
@bjorkert bjorkert marked this pull request as ready for review March 25, 2024 13:57
@marionbarker marionbarker merged commit 9e12b8f into dev Mar 25, 2024
@marionbarker marionbarker deleted the testflight-build-expiration branch April 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants