-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the include
filter
#28
Comments
thanks @pulkitsinghal, will be checking it. |
I'm thinking that this also ties into the finishing #24 first ... should I make the include filter smart enough to look at the mappings and then form queries differently to support both Should I do the work in increments so that until posts for children #24 (in parent/child) aren't done ... only nested mappings are supported for includes. Honestly I am not a fan of |
Include filter was not working. There was a discussion about implementation of include filter in issue #28 which is still pending. I have implemented the minimum workflow to make include filter work until we optimise it for better performance.
- Fixed Issue #79 - Multiple where clause filter support without `and` filter - this issue was fixed in PR #78 - Fixed Issue #73 - Nested and, or filter support added - this issue was fixed in PR #75 - Fixed Issue #73 - `inq`,`nin`,`between`,`neq` filter support added - this issue was fixed in PR #75 - Fixed Issue #28 - Include filter added - Minimum workflow to make include filter work until we optimize it for better performance. This issue was fixed in PR #71
@pulkitsinghal Please close this issue if you think the latest release serves our purpose. I know you want a better solution for include rather than using loopback's fallback way. Please refer to the commit above and do the needful. |
@aquid - How does the |
Notes to learn from mongodb's implementation:
In the meantime a workaround is to use the
native
filter instead ofinclude
to write the query using ES's DSL instead of loopback. Ofcourse you need to have already setup parent-child mappings in the datasource correctly no matter what.The text was updated successfully, but these errors were encountered: