Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid 'USING ' on FULLTEXT index #471

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Conversation

forno
Copy link
Contributor

@forno forno commented Sep 12, 2022

Signed-off-by: FORNO forno@xmaho.link

Implements #470

Result of test on my machine

  1978 passing (1m)
  216 pending
  3 failing
  1) MySQL datetime handling
       should allow use of fractional seconds:

      AssertionError: expected '1971-06-22T03:34:56.789Z' to equal '1971-06-22T12:34:56.789Z'
      + expected - actual

      -1971-06-22T03:34:56.789Z
      +1971-06-22T12:34:56.789Z
  2) MySQL connector
       should auto migrate/update foreign keys in tables:

      Uncaught AssertionError: expected 0 to be 1
      + expected - actual

      -0
      +1
3) MySQL connector
       should auto migrate/update foreign keys with onUpdate and onDelete in tables:

      Uncaught AssertionError: expected 0 to be 1
      + expected - actual

      -0
      +1

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

Signed-off-by: FORNO <forno@xmaho.link>
@@ -369,7 +369,7 @@ function mixinMigration(MySQL, mysql) {
const indexName = self.client.escapeId(propName);
let type = '';
let kind = '';
if (i.type) {
if (i.type && i.kind.toUpperCase() !== 'FULLTEXT') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatdubeysf Can you review this once ? LGTM.

@samarpanB samarpanB changed the title feat: Avoid 'USING ' on FULLTEXT index feat: avoid 'USING ' on FULLTEXT index Nov 14, 2022
Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, and the errrored tests don't seem to be related to this change. We should be good to merge 👍

Will open a separate issue to work on fixing the CI pipeline

@achrinza achrinza merged commit 0d54635 into loopbackio:master Nov 20, 2022
@achrinza achrinza mentioned this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants