Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back Node.js v12 tests #520

Closed
achrinza opened this issue Oct 2, 2022 · 4 comments
Closed

Add back Node.js v12 tests #520

achrinza opened this issue Oct 2, 2022 · 4 comments
Labels

Comments

@achrinza
Copy link
Member

achrinza commented Oct 2, 2022

Dropping support would be considered a breaking change. Until we agree to do a server major bump (e.g. with other breaking changes), we should continue testing older versions of Node.js.

@achrinza achrinza added the bug label Oct 2, 2022
@dhmlau
Copy link
Member

dhmlau commented Nov 7, 2022

With Node.js 12 EOL April 2022, it makes sense to drop the support. My question would be whether we want to wait till next April so Node.js 14 to go EOL, then we have a major version bump at that time.

Reference: Node.js LTS schedule https://github.com/nodejs/Release

@samarpanB
Copy link
Contributor

I can do this change as part of my PR here - #524. Let me know what you guys think ? @achrinza @dhmlau

@achrinza
Copy link
Member Author

@samarpanB Im ok with that 👍

@samarpanB
Copy link
Contributor

Closing since node12 support has been dropped now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants