-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postgresql): add support for multiple insert in one query using createAll() of connector #524
Conversation
8fb334d
to
8cfd15b
Compare
@@ -46,7 +46,7 @@ | |||
"juggler-v3": "file:./deps/juggler-v3", | |||
"juggler-v4": "file:./deps/juggler-v4", | |||
"lodash": "^4.17.4", | |||
"loopback-datasource-juggler": "^3.0.0 || ^4.0.0", | |||
"loopback-datasource-juggler": "^4.28.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, though loopback-datasource-juggle@3.x reaches EOL. Together with the discussion in #520, it might be a good time to do it.
@loopbackio/loopback-maintainers, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes its a breaking change. So I agree to go ahead with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for making a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…createAll() of connector BREAKING CHANGE: This drops explicit, documented support for Node.js v10, v11, v12, v13, v15, v17 Signed-off-by: Samarpan Bhattacharya <this.is.samy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please make sure CI passes before merging. Thanks.
All checks passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks passing; LGTM 👍
BREAKING CHANGE: This drops explicit, documented support for Node.js v10, v11, v12, v13, v15, v17
Signed-off-by: Samarpan Bhattacharya this.is.samy@gmail.com
Fixes #523
See also loopbackio/loopback-next#3357
Checklist
npm test
passes on your machine