Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace request with postman-request fork as a drop-in replacement #179

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

samarpanB
Copy link
Contributor

@samarpanB samarpanB commented Mar 3, 2024

Replace deprecated request module with a better maintained fork of it postman-request. This can be a drop-in replacement to ensure security patches and upgrades are easier.

Fixes #147 , #158

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

Signed-off-by: Samarpan Bhattacharya <this.is.samy@gmail.com>
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dhmlau dhmlau merged commit 3d0ea7b into master Mar 4, 2024
5 checks passed
@dhmlau dhmlau deleted the gh-147 branch March 4, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace request with axios
2 participants