Fix order of query results #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh24
approved these changes
May 1, 2017
b-admike
approved these changes
May 1, 2017
dhmlau
reviewed
May 1, 2017
| @@ -341,8 +341,8 @@ describe('basic-querying', function() { | |||
| should.not.exist(err); | |||
| should.exist(users); | |||
| users.should.have.property('length', 2); | |||
| users[0].name.should.equal('John Lennon'); | |||
| users[1].name.should.equal('Paul McCartney'); | |||
| should(users[0].name).be.oneOf('John Lennon', 'Paul McCartney'); | |||
There was a problem hiding this comment.
if we don't care about the order, would have.members be a better option?
There was a problem hiding this comment.
Same thing.. there are different ways of doing it.
|
Force-merged due to unrelated grpc failure hanging this one up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The order of the instances in the array could be reverted sometimes. That's is causing CI failures sometimes.
so users[0].name could be 'John Lennon' or Paul McCartney' and the same for users[1].name,
so the fix is trying to ignore the order of names but to ensure that both names are still there.