Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for atomic upsertWithWhere #1864

Merged
merged 1 commit into from Sep 25, 2020

Conversation

mrbatista
Copy link
Contributor

@mrbatista mrbatista commented Sep 2, 2020

See loopbackio/loopback-connector-mongodb#563

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@mrbatista mrbatista force-pushed the atomic-upsert-with-where branch 4 times, most recently from 8633538 to 7df84a2 Compare September 2, 2020 14:28
@mrbatista mrbatista changed the title disable test for atomic upsertWithWhere add tests for atomic upsertWithWhere Sep 19, 2020
Introduce the new property atomicUpsertWithWhere for
connector that implement specific method.
See loopbackio/loopback-connector-mongodb#563
for mongodb implementation.

Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. The 2 downstream failures are not related.
They also fail on master https://github.com/strongloop/loopback-datasource-juggler/pull/1860/commits

@jannyHou jannyHou merged commit 76acf33 into loopbackio:master Sep 25, 2020
jannyHou added a commit that referenced this pull request Sep 25, 2020
 * chore: add test for atomic upsertWithWhere (#1864) (Matteo Padovano)
 * chore: update PR template (#1863) (Diana Lau)
 * update PR template to include DCO (#1859) (Diana Lau)
 * chore: add contributing section to readme (#1858) (Diana Lau)
jannyHou pushed a commit that referenced this pull request Oct 15, 2020
Introduce the new property atomicUpsertWithWhere for
connector that implement specific method.
See loopbackio/loopback-connector-mongodb#563
for mongodb implementation.

Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou pushed a commit that referenced this pull request Oct 19, 2020
Introduce the new property atomicUpsertWithWhere for
connector that implement specific method.
See loopbackio/loopback-connector-mongodb#563
for mongodb implementation.

Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou pushed a commit that referenced this pull request Nov 23, 2020
Introduce the new property atomicUpsertWithWhere for
connector that implement specific method.
See loopbackio/loopback-connector-mongodb#563
for mongodb implementation.

Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou pushed a commit that referenced this pull request Nov 23, 2020
Introduce the new property atomicUpsertWithWhere for
connector that implement specific method.
See loopbackio/loopback-connector-mongodb#563
for mongodb implementation.

Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou added a commit that referenced this pull request Nov 24, 2020
Introduce the new property atomicUpsertWithWhere for
connector that implement specific method.
See loopbackio/loopback-connector-mongodb#563
for mongodb implementation.

Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>

Co-authored-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou added a commit that referenced this pull request Nov 27, 2020
 * chore: add test for atomic upsertWithWhere (#1864) (#1871) (Janny)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants