New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for atomic upsertWithWhere #1864
Merged
jannyHou
merged 1 commit into
loopbackio:master
from
mrbatista:atomic-upsert-with-where
Sep 25, 2020
Merged
add tests for atomic upsertWithWhere #1864
jannyHou
merged 1 commit into
loopbackio:master
from
mrbatista:atomic-upsert-with-where
Sep 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbatista
requested review from
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
September 2, 2020 12:58
mrbatista
force-pushed
the
atomic-upsert-with-where
branch
from
September 2, 2020 12:59
72c6463
to
e6d6979
Compare
4 tasks
mrbatista
force-pushed
the
atomic-upsert-with-where
branch
4 times, most recently
from
September 2, 2020 14:28
8633538
to
7df84a2
Compare
mrbatista
force-pushed
the
atomic-upsert-with-where
branch
from
September 19, 2020 09:27
7df84a2
to
b0a3d39
Compare
mrbatista
changed the title
disable test for atomic upsertWithWhere
add tests for atomic upsertWithWhere
Sep 19, 2020
mrbatista
force-pushed
the
atomic-upsert-with-where
branch
from
September 19, 2020 09:29
b0a3d39
to
ef36ded
Compare
Introduce the new property atomicUpsertWithWhere for connector that implement specific method. See loopbackio/loopback-connector-mongodb#563 for mongodb implementation. Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
mrbatista
force-pushed
the
atomic-upsert-with-where
branch
from
September 19, 2020 10:02
ef36ded
to
f6d1f64
Compare
jannyHou
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. The 2 downstream failures are not related.
They also fail on master https://github.com/strongloop/loopback-datasource-juggler/pull/1860/commits
agnes512
approved these changes
Sep 25, 2020
jannyHou
added a commit
that referenced
this pull request
Sep 25, 2020
jannyHou
pushed a commit
that referenced
this pull request
Oct 15, 2020
Introduce the new property atomicUpsertWithWhere for connector that implement specific method. See loopbackio/loopback-connector-mongodb#563 for mongodb implementation. Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
5 tasks
jannyHou
pushed a commit
that referenced
this pull request
Oct 19, 2020
Introduce the new property atomicUpsertWithWhere for connector that implement specific method. See loopbackio/loopback-connector-mongodb#563 for mongodb implementation. Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou
pushed a commit
that referenced
this pull request
Nov 23, 2020
Introduce the new property atomicUpsertWithWhere for connector that implement specific method. See loopbackio/loopback-connector-mongodb#563 for mongodb implementation. Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou
pushed a commit
that referenced
this pull request
Nov 23, 2020
Introduce the new property atomicUpsertWithWhere for connector that implement specific method. See loopbackio/loopback-connector-mongodb#563 for mongodb implementation. Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com>
jannyHou
added a commit
that referenced
this pull request
Nov 24, 2020
Introduce the new property atomicUpsertWithWhere for connector that implement specific method. See loopbackio/loopback-connector-mongodb#563 for mongodb implementation. Signed-off-by: Matteo Padovano <mrbatista@users.noreply.github.com> Co-authored-by: Matteo Padovano <mrbatista@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See loopbackio/loopback-connector-mongodb#563
Checklist
npm test
passes on your machine