Promisify 'automigrate' #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PradnyaBaviskar
force-pushed
the
issue-418
branch
from
e107090
to
6bbbc6b
Compare
| if(cb.promise) { | ||
| process.nextTick(cb); | ||
| return cb.promise; | ||
| } | ||
| return cb && process.nextTick(cb); |
There was a problem hiding this comment.
Please simplify this code, cb is always defined thanks to L778.
I'd personally write this block as follows:
if (!this.connector.automigrate) {
process.nextTick(cb);
return cb.promise;
}
|
@PradnyaBaviskar nice! I have reviewed the patch. The implementation is good in principle, I'd like you to simplify it a bit - see my comments above. |
|
@slnode test please |
PradnyaBaviskar
force-pushed
the
issue-418
branch
from
6bbbc6b
to
f4f13a6
Compare
|
Addressed the comments above. @bajtos , Please review. |
|
Landed, thank you! |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect strongloop/loopback#418
This PL, provides
promisesupport toautomigratemethod of juggler's datasource.@bajtos - can you review?