fix: mark HasManyRepository as a readonly property

loopbackio · Oct 5, 2018 · 39227eb · 39227eb
1 parent 942e523
commit 39227eb
Show file tree

Hide file tree

Showing 9 changed files with 29 additions and 9 deletions.
diff --git a/docs/site/HasMany-relation.md b/docs/site/HasMany-relation.md
@@ -131,7 +131,10 @@ class CustomerRepository extends DefaultCrudRepository<
   Customer,
   typeof Customer.prototype.id
 > {
-  public orders: HasManyRepositoryFactory<Order, typeof Customer.prototype.id>;
+  public readonly orders: HasManyRepositoryFactory<
+    Order,
+    typeof Customer.prototype.id
+  >;
   constructor(
     @inject('datasources.db') protected db: juggler.DataSource,
     @repository.getter(OrderRepository)

diff --git a/docs/site/todo-list-tutorial-repository.md b/docs/site/todo-list-tutorial-repository.md
@@ -56,7 +56,10 @@ export class TodoListRepository extends DefaultCrudRepository<
   TodoList,
   typeof TodoList.prototype.id
 > {
-  public todos: HasManyRepositoryFactory<Todo, typeof TodoList.prototype.id>;
+  public readonly todos: HasManyRepositoryFactory<
+    Todo,
+    typeof TodoList.prototype.id
+  >;
 
   constructor(
     @inject('datasources.db') dataSource: juggler.DataSource,

diff --git a/examples/todo-list/src/repositories/todo-list.repository.ts b/examples/todo-list/src/repositories/todo-list.repository.ts
@@ -17,7 +17,10 @@ export class TodoListRepository extends DefaultCrudRepository<
   TodoList,
   typeof TodoList.prototype.id
 > {
-  public todos: HasManyRepositoryFactory<Todo, typeof TodoList.prototype.id>;
+  public readonly todos: HasManyRepositoryFactory<
+    Todo,
+    typeof TodoList.prototype.id
+  >;
 
   constructor(
     @inject('datasources.db') dataSource: juggler.DataSource,

diff --git a/examples/todo-list/src/repositories/todo.repository.ts b/examples/todo-list/src/repositories/todo.repository.ts
@@ -17,7 +17,10 @@ export class TodoRepository extends DefaultCrudRepository<
   Todo,
   typeof Todo.prototype.id
 > {
-  public todoList: BelongsToAccessor<TodoList, typeof Todo.prototype.id>;
+  public readonly todoList: BelongsToAccessor<
+    TodoList,
+    typeof Todo.prototype.id
+  >;
 
   constructor(
     @inject('datasources.db') dataSource: juggler.DataSource,

diff --git a/examples/todo-list/test/unit/controllers/todo-list-todo.controller.unit.ts b/examples/todo-list/test/unit/controllers/todo-list-todo.controller.unit.ts
@@ -150,7 +150,9 @@ describe('TodoController', () => {
       .stub()
       .withArgs(aTodoListWithId.id!)
       .returns(constrainedTodoRepo);
-    todoListRepo.todos = todos;
+
+    // tslint:disable-next-line:no-any
+    (todoListRepo as any).todos = todos;
 
     // Setup CRUD fakes
     ({create, find, patch, delete: del} = constrainedTodoRepo.stubs);

diff --git a/packages/repository/src/repositories/legacy-juggler-bridge.ts b/packages/repository/src/repositories/legacy-juggler-bridge.ts
@@ -151,7 +151,7 @@ export class DefaultCrudRepository<T extends Entity, ID>
    *   Customer,
    *   typeof Customer.prototype.id
    * > {
-   *   public orders: HasManyRepositoryFactory<Order, typeof Customer.prototype.id>;
+   *   public readonly orders: HasManyRepositoryFactory<Order, typeof Customer.prototype.id>;
    *
    *   constructor(
    *     protected db: juggler.DataSource,

diff --git a/packages/repository/test/acceptance/has-many-without-di.relation.acceptance.ts b/packages/repository/test/acceptance/has-many-without-di.relation.acceptance.ts
@@ -132,7 +132,7 @@ describe('HasMany relation', () => {
     Customer,
     typeof Customer.prototype.id
   > {
-    public orders: HasManyRepositoryFactory<
+    public readonly orders: HasManyRepositoryFactory<
       Order,
       typeof Customer.prototype.id
     >;

diff --git a/packages/repository/test/fixtures/repositories/customer.repository.ts b/packages/repository/test/fixtures/repositories/customer.repository.ts
@@ -17,7 +17,10 @@ export class CustomerRepository extends DefaultCrudRepository<
   Customer,
   typeof Customer.prototype.id
 > {
-  public orders: HasManyRepositoryFactory<Order, typeof Customer.prototype.id>;
+  public readonly orders: HasManyRepositoryFactory<
+    Order,
+    typeof Customer.prototype.id
+  >;
   constructor(
     @inject('datasources.db') protected db: juggler.DataSource,
     @repository.getter('OrderRepository')

diff --git a/packages/repository/test/fixtures/repositories/order.repository.ts b/packages/repository/test/fixtures/repositories/order.repository.ts
@@ -17,7 +17,10 @@ export class OrderRepository extends DefaultCrudRepository<
   Order,
   typeof Order.prototype.id
 > {
-  public customer: BelongsToAccessor<Customer, typeof Order.prototype.id>;
+  public readonly customer: BelongsToAccessor<
+    Customer,
+    typeof Order.prototype.id
+  >;
 
   constructor(
     @inject('datasources.db') protected db: juggler.DataSource,