Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] switch to typescript-tslint-plugin #2026

Closed
5 tasks
bajtos opened this issue Nov 13, 2018 · 1 comment
Closed
5 tasks

[SPIKE] switch to typescript-tslint-plugin #2026

bajtos opened this issue Nov 13, 2018 · 1 comment
Labels
Internal Tooling Issues related to our tooling and monorepo infrastructore spike

Comments

@bajtos
Copy link
Member

bajtos commented Nov 13, 2018

Replace a standalone tslint build step with configuring tslint as a TypeScript language service plugin. See https://github.com/Microsoft/typescript-tslint-plugin

Acceptance criteria

  • Find if there are any features that we rely on and that are not supported by typescript-tslint-plugin
  • Compare the performance. E.g. run time npm test before and after the switch and check the time difference.
  • Find out how to upgrade @loopback/build and asses impact of such changes on existing projects. E.g. if we merge tslint.json with tslint.build.json, then I suspect we will break all existing projects.
  • Review the todo list below and add any missing steps.
  • Review DEVELOPING.md and indentify places that will need an update.

A preliminary task list for the real work:

  • npm run build runs tslint as part of the compilation step
  • all tslint-related tasks (tslint, tslint:fix) are removed
  • tslint.config and tslint.build.config are merged into a single configuration. This applies to all packages in our monorepo.
  • Instructions for VSCode users are telling developers to disable vscode-tslint extension.
  • New projects scaffolded via lb4 will use typescript-tslint-plugin too.
  • A blog post to publicize this change. Explain what is changing for LB contributors, what is changing for LB app developers, what (if any) migration is required for existing projects.
@bajtos bajtos added developer-experience Issues affecting ease of use and overall experience of LB users spike labels Nov 13, 2018
@bajtos bajtos added Internal Tooling Issues related to our tooling and monorepo infrastructore and removed developer-experience Issues affecting ease of use and overall experience of LB users labels Jan 24, 2019
@bajtos
Copy link
Member Author

bajtos commented Sep 12, 2019

This spike is no longer relevant, we have replaced tslint with typescript-eslint, see #2492

@bajtos bajtos closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Tooling Issues related to our tooling and monorepo infrastructore spike
Projects
None yet
Development

No branches or pull requests

1 participant