Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Resolve the relational path's url #2855

Closed
jannyHou opened this issue May 9, 2019 · 5 comments
Closed

[Spike] Resolve the relational path's url #2855

jannyHou opened this issue May 9, 2019 · 5 comments
Labels
needs grooming Relations Model relations (has many, etc.) spike

Comments

@jannyHou
Copy link
Contributor

jannyHou commented May 9, 2019

Description / Steps to reproduce / Feature proposal

This is a spike of story #2483:
Before we construct the relation controller from the static file, we need to decide where to define the relation endpoints(in a new controller class or in "modelFrom"'s controller), and how to resolve the relational path's url.

Copy from the original discuss:

This story may need a spike to figure out how to map the relational paths to REST endpoints.

Reference story:
Hierarchical resource locator: #802

/Users/{id}/orders

* delegate to user controller

* user controller interprets the `/orders`, resolve the url

* delegate to order controller

Proposal:
Delegate the url resolve to controller, instead of defining the path pattern in relation controller

@dhmlau
Copy link
Member

dhmlau commented May 9, 2019

@b-admike, could you please add the acceptance criteria? thanks.

@bajtos
Copy link
Member

bajtos commented May 13, 2019

We should be using the same approach we already have in place for relations, where a new controller class is created for every relation. E.g. UserOrdersController to handle all endpoints in /Users/{id}/orders path space.

@bajtos
Copy link
Member

bajtos commented May 13, 2019

@dhmlau added 2019Q2 p1 labels 3 days ago

I think it's too early to work on this spike and the story "From relation definition to REST API with no repository/controller classes #2483" in general. We need to implement "From model definition to REST API with no custom repository/controller classes #2036" first, because relations will leverage the foundational blocks provided #2036.

@dhmlau
Copy link
Member

dhmlau commented May 13, 2019

@bajtos, thanks for the info. Since #2036 (which needs to be implemented first) is planning for 2019Q3, I'll move this spike to Q3 for now.

@jannyHou
Copy link
Contributor Author

jannyHou commented Oct 8, 2019

Close it in favor of #3896

@jannyHou jannyHou closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs grooming Relations Model relations (has many, etc.) spike
Projects
None yet
Development

No branches or pull requests

3 participants