Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDesignTypeForProperty wrong code documentation #6522

Closed
mdbetancourt opened this issue Oct 9, 2020 · 0 comments · Fixed by #6701
Closed

getDesignTypeForProperty wrong code documentation #6522

mdbetancourt opened this issue Oct 9, 2020 · 0 comments · Fixed by #6701

Comments

@mdbetancourt
Copy link
Contributor

i notice the following documentation is not true

https://github.com/strongloop/loopback-next/blob/a666071e360b06c2f2c620d0aefd82d1ff38cf0c/packages/metadata/src/inspector.ts#L213-L215

there say

Design time metadata. The return value is undefined when:
The property has type undefined, null or a complex type like
Partial<MyModel>, string | number, string[].

but is only true for undefined and null because the anothers complex examples returns Object, Object, Array respectively

@mdbetancourt mdbetancourt changed the title confuse and wrong documentation getDesignTypeForProperty wrong code documentation Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant