fix: export decorators for backward compatibility #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
changed the title
jannyHou
changed the title
raymondfeng
reviewed
Jan 10, 2018
|
|
||
| describe('backward-compatibility', () => { | ||
| it('exports functions from @loopback/openapi-v2', async () => { | ||
| try { |
There was a problem hiding this comment.
No try-catch is needed. The test passes if it complies.
raymondfeng
reviewed
Jan 10, 2018
| describe('backward-compatibility', () => { | ||
| it('exports functions from @loopback/openapi-v2', async () => { | ||
| try { | ||
| class Test { |
There was a problem hiding this comment.
You need to add /* tslint:disable-next-line:no-unused-variable */ to fix the style issue:
raymondfeng
requested changes
Jan 10, 2018
jannyHou
force-pushed
the
export-v2
branch
2 times, most recently
from
5b2bedd
to
1d718bf
Compare
|
@slnode test please |
|
@raymondfeng thank you for reviewing, feedbacks applied but after rebasing, module Triggered a new build. |
|
@slnode test please |
raymondfeng
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: error TS2305: Module has no exported member 'get'. strongloop/loopback#3753
test cases