Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General review and testing #55

Closed
crandmck opened this issue Sep 20, 2016 · 10 comments
Closed

General review and testing #55

crandmck opened this issue Sep 20, 2016 · 10 comments
Assignees

Comments

@crandmck
Copy link
Contributor

crandmck commented Sep 20, 2016

Before launch, it would be good to go through the content in http://loopback.io/doc/en/lb2/ and do thorough review for accuracy, completeness, formatting, etc.

@bajtos bajtos added the #plan label Sep 20, 2016
@bajtos
Copy link
Member

bajtos commented Sep 20, 2016

Nice to have: which pages should be changed in LB 3.x docs?

@crandmck
Copy link
Contributor Author

@davidcheung Let me know if you have questions. We're launching the site next week, so please have a look ASAP.

@davidcheung
Copy link
Contributor

@crandmck will get on it today

@davidcheung
Copy link
Contributor

davidcheung commented Sep 26, 2016

Suggestion

  • Table of content always contains the parent item "LoopBack 2.0"
    i find it a little confusing, would rather have it removed or named Home if its customizable, for example if im trying to create simple api and the first item on table of content sends me back to homepage.

  • create an application should fall under getting started? not sure whats the best way of organizing the order but currently it goes as follow, where it teaches u to do all sorts of things, then create an application (but then it follows with managing users, authentication which are good flow)

    • Getting started with LoopBack
      • Create a simple API
      • Use API Explorer
      • Connect your API to a data source
      • Extend your API
      • Add a static web page
      • Add a custom Express route
      • Next steps
    • Getting started part II
      • Introducing the Coffee Shop Reviews app
      • Create new data source
      • Create new models
      • Define model relations
      • Define access controls
      • Define a remote hook
      • Create AngularJS client
      • Learn more
    • Security advisories
    • Creating an application

Fixables

Content missing

@crandmck
Copy link
Contributor Author

Table of content always contains the parent item "LoopBack 2.0"

That was just a glitch... fixed.

Create an application should fall under getting started?

[http://loopback.io/doc/en/lb2/Create-a-simple-API.html](Create a simple API) basically covers that territory. (BTW, Issac wanted to call it "create an API" and not "create an app"). In contrast, Creating an application is more of a general task-oriented article vs. a tutorial.

Sometimes when left nav expands it goes too far

Created #60 to fix this.

Glossary falls under Loopback-core-concept nav...

Yes, it used to be under "Reference" but it really got lost there. I wanted to make it more prominent, and that was the best place I could find.

Broken Link where it says Process manager in blue bubble,...

Fixed the link, and changed wording a bit.

in the table of overview, Object and Array link is wrong

Which article?

http://loopback.io/doc/en/lb2/Connecting-to-MySQL.html enum link should be http://loopback.io/doc/en/lb2/MySQL-connector.html#enum

This comes from the MySQL connector README; need to fix it there. Same with Informix.

Re: the nav bar glitches, I'm still working those out. I'll need to rework the navbar a bit, because Sequoia reimplemented the widget and it works a bit differently. Will comment on those once I get 'er done.

@Sequoia
Copy link
Contributor

Sequoia commented Sep 27, 2016

Left nav Built-in models REST API , maybe due to 2 items same name, the first one always links to current URL.

As @crandmck mentioned, we discussed the possibilities for side-nav "container"/folder items and the following seemed to be the options:

  1. parent/"folder" never has a page, always redirects to first child
  2. parent/"folder" always has a page
  3. parent/"folder" sometimes has a page, sometimes doesn't.

Confluence allowed for option 3 above. I argue(d) that this behavior is confusing as it makes menu clicks less predictable (will this send me to a page? to the child? no page?). Option 1 and option 2 require more or less equal reworking of content organization: either move all "folder" pages to "folder> first child page" for solution 1, or ensure that all "folder" menu items have their own page they link to, overview of the section e.g.

I went with option 2 above, which will require those "folder" items with no page to have one created for them to point to. None of the solutions is perfect but that one seemed to create the most intuitive, predictable UX (click menu link, it takes you to a page, 100% of the time) so that's what we went with! It's certainly changeable but to my mind it's the sort of bike-shed issue that's best to just pick a solution & go with it. 😸

@crandmck
Copy link
Contributor Author

Actually, on the old Confluence site https://docs.strongloop.com/ every "leaf" in the navigation "tree" corresponds to a page (which may or may not have children). If you click on the + then it expands the children in the nav tree; if you click on the page title, it displays the page and expands the children in the nav tree.

This is also how it's currently working on loopback.io, which is great and exactly what I asked for.

However, there are still a few problems with how second-level containers work, that I suspect come from the server-side (Jekyll/Liquid) behavior. And I would really like to be able to have one more level of nesting.... but I'll open a separate issue for these.

@davidcheung
Copy link
Contributor

davidcheung commented Sep 27, 2016

In this scenario to be specific,
why dont we move the url from the child to the sub-parent, then delete the child since they are duplicates
https://github.com/strongloop/loopback.io/blob/ef191bba2e7561192f684226d3eae221da1206df/_data/sidebars/lb2_sidebar.yml#L345-L352

because right now on http://loopback.io/doc/en/lb2/Model-property-reference.html, when you click on Built-in models REST API's text it does nothing

basically this #64

@crandmck
Copy link
Contributor Author

@davidcheung Yes, there are quite a few examples of similar problems. I'm working on the sidebar right now to address these. Will let you know when I'm done so you can check it out.

@crandmck
Copy link
Contributor Author

So, I've fixed the sidebar (David pointed out one issue I missed, and I fixed it). So, I think we can close this, since we're essentially "launching" the site tomorrow with the blog post, etc.. Thanks for your help @davidcheung!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants