1.0.0

[loay]

See the proposal in strongloop/loopback#1650 (comment) for details.

Connect to strongloop/loopback#1650

[bajtos]

iojs is no longer relevant, please add "4" (LTS) and "5" (stable) instead

[loay]

Done

[bajtos]

@loay your coding style seems a bit inconsistent to me, some lines have trailing semi colon, some don't. Please add eslint with eslint-config-loopback and fix any issues reported by linter.

[bajtos]

Huh, why is this needed? setImmediate is always a function in Node.js 0.10 and newer.

[bajtos]

Please use a different file name than test/test.js, one that describes more what is being tested. For example index.test.js or perhaps integration.test.js

[bajtos]

Uh, maintaining two copies of test cases that are mostly identical is a nightmare. It's difficult to tell what is specific for the case when debug==true and what's same for both.

Ideally, the tests should be written in such way, that tests for things like nosniff header that do not depend on debug will use the default value and should be written in such way that they pass regardless of what's the default value. Then there should be tests focused solely on debug:false, debug:true and debug:undefined.

[bajtos]

If you want to run the same set of tests with different config options, then create parameterised test suite instead:

var SCENARIOS = [
  { debug: false }, 
  { debug: true }
];

SCENARIOS.forEach(function(sc) {
  describe('strongErrorHandler with ' + JSON.stringify(sc), function() {
    // run the tests and use `sc.debug` for the debug option passed to `createServer`
  }
}

However, I think that's an overkill here.

[bajtos]

This does not follow the spec, please rework and add unit-tests too.

strongloop/loopback#1650 (comment)

JSON response fields

1. debug:true - all error fields are sent in the HTTP response
2. debug:false & status code is 4xx - the error object contains the following fields:
   • name
   • message - as provided by Error.message
   • statusCode
   • details
   • + any fields from options.safeFields
3. debug:false & status code is 5xx or <400 or falsey - the error object
   contains the following fields
   • statusCode
   • message - the string from HTTP spec
   • + any fields from options.safeFields

[bajtos]

Also note that the rules outlined above applies to other content types too. I.e. the message should be always the string from HTTP spec when statusCode is not 4xx, regardless whether we render HTML, JSON or text.

[loay]

added the 3 conditions in JSON

[loay]

@bajtos
I am missing:

• cache the html template
• clean up the test cases.

[loay]

@bajtos
PTAL

[bajtos]

@loay I am afraid there is still too many missing pieces to address before this can be landed. I have reworked some parts of this patch in #9 and created new issues to keep track of the remaining work.