Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: align CI configuration #252

Merged
merged 1 commit into from
Nov 9, 2023
Merged

ci: align CI configuration #252

merged 1 commit into from
Nov 9, 2023

Conversation

achrinza
Copy link
Member

@achrinza achrinza commented Nov 7, 2023

Description

This combines several changes to re-align the CI configuration with the org-wide CI configuration standards.

It also fixes the use of "vague Git tags".

Related issues

See Git commit body.

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@achrinza achrinza force-pushed the align-ci branch 14 times, most recently from 6751f37 to a6f459b Compare November 8, 2023 04:17
@achrinza achrinza requested a review from dhmlau November 8, 2023 07:28
Comment on lines +65 to +70
api.github.com:443
github.com:443
nodejs.org:443
registry.npmjs.org:443
Copy link
Member Author

@achrinza achrinza Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following URLs are required due to Node.js 21 not yet being bundled with the Github-hosted runner:

  • api.github.com:443
  • nodejs.org:443

@achrinza achrinza force-pushed the align-ci branch 3 times, most recently from e94a396 to af2cc8d Compare November 9, 2023 07:57
@achrinza achrinza merged commit 1b9571f into master Nov 9, 2023
12 checks passed
@achrinza achrinza deleted the align-ci branch November 9, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant