Add attachments #237
Add attachments #237
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
src/http.js
Outdated
|
|
||
| if (typeof data === 'string') { | ||
| if (typeof data === 'string' && attachments.lemgth === 0) { |
There was a problem hiding this comment.
Typo, it should be attachments.length.
src/http.js
Outdated
| var mergeOptions = ['headers']; | ||
| if (exoptions) { | ||
| var attachments = exoptions.attachments || []; |
src/http.js
Outdated
|
|
||
| if (typeof data === 'string') { | ||
| if (typeof data === 'string' && attachments.lemgth) { |
There was a problem hiding this comment.
attachments.lemgth => attachments.length === 0?
There was a problem hiding this comment.
I did not understand what the correction would be
There was a problem hiding this comment.
Please note length is correct instead of lemgth.
There was a problem hiding this comment.
I assume you are testing if the attachments array is empty.
There was a problem hiding this comment.
silly mistake, now it goes
|
@allanmayanei1 It would be good to add a test case for this new feature. |
|
@allanmayanei1 The changes look good now. Would you please squash all commits into one? |
changes will rise when ? |
|
@allanmayanei1 I have cleaned up the commit history in your repo. |
|
@raymondfeng Thank you, something is missing? |
|
Merged and published. Thanks for the contribution. |
|
I thank you |
Description
Add support attachments the file
Related issues
Checklist
guide