Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Updating polyglot version to v1.2.2 #170

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

ShivanshVij
Copy link
Member

@ShivanshVij ShivanshVij commented Mar 27, 2024

Description

This PR upgrades all dependencies to the latest version. Specifically it upgrades polyglot to v1.2.2 which comes with significant performance improvements.

Testing

Multiple test cases were updated to function with the updated polyglot dependency.

Benchmarking

Frisbee tries to adhere to strict performance requirements, so please make sure to run go test -bench=. ./... and paste the results below:

benchmark                                                                  old MB/s     new MB/s     speedup
BenchmarkAsyncThroughputPipe/32_Bytes-12                                   88.01        89.49        1.02x
BenchmarkAsyncThroughputPipe/512_Bytes-12                                  1250.63      1263.23      1.01x
BenchmarkAsyncThroughputPipe/1024_Bytes-12                                 2444.60      2470.54      1.01x
BenchmarkAsyncThroughputPipe/2048_Bytes-12                                 4194.98      4300.94      1.03x
BenchmarkAsyncThroughputPipe/4096_Bytes-12                                 6335.80      6539.51      1.03x
BenchmarkAsyncThroughputNetwork/32_Bytes-12                                86.49        88.96        1.03x
BenchmarkAsyncThroughputNetwork/512_Bytes-12                               1160.80      1189.47      1.02x
BenchmarkAsyncThroughputNetwork/1024_Bytes-12                              2272.24      2329.76      1.03x
BenchmarkAsyncThroughputNetwork/2048_Bytes-12                              3799.35      3892.61      1.02x
BenchmarkAsyncThroughputNetwork/4096_Bytes-12                              5538.30      5441.94      0.98x
BenchmarkAsyncThroughputNetworkMultiple/1_Pair,_32_Bytes-12                86.03        89.19        1.04x
BenchmarkAsyncThroughputNetworkMultiple/2_Pair,_32_Bytes-12                88.23        87.37        0.99x
BenchmarkAsyncThroughputNetworkMultiple/5_Pair,_32_Bytes-12                58.06        72.20        1.24x
BenchmarkAsyncThroughputNetworkMultiple/10_Pair,_32_Bytes-12               31.41        31.08        0.99x
BenchmarkAsyncThroughputNetworkMultiple/Half_CPU_Pair,_32_Bytes-12         56.36        58.95        1.05x
BenchmarkAsyncThroughputNetworkMultiple/CPU_Pair,_32_Bytes-12              26.66        26.79        1.00x
BenchmarkAsyncThroughputNetworkMultiple/Double_CPU_Pair,_32_Bytes-12       15.11        15.58        1.03x
BenchmarkAsyncThroughputNetworkMultiple/1_Pair,_512_Bytes-12               1183.99      1197.71      1.01x
BenchmarkAsyncThroughputNetworkMultiple/2_Pair,_512_Bytes-12               1220.16      1218.34      1.00x
BenchmarkAsyncThroughputNetworkMultiple/5_Pair,_512_Bytes-12               944.76       916.59       0.97x
BenchmarkAsyncThroughputNetworkMultiple/10_Pair,_512_Bytes-12              421.05       424.09       1.01x
BenchmarkAsyncThroughputNetworkMultiple/Half_CPU_Pair,_512_Bytes-12        737.56       810.57       1.10x
BenchmarkAsyncThroughputNetworkMultiple/CPU_Pair,_512_Bytes-12             360.91       365.58       1.01x
BenchmarkAsyncThroughputNetworkMultiple/Double_CPU_Pair,_512_Bytes-12      223.45       219.68       0.98x
BenchmarkAsyncThroughputNetworkMultiple/1_Pair,_4096_Bytes-12              5543.70      5538.04      1.00x
BenchmarkAsyncThroughputNetworkMultiple/2_Pair,_4096_Bytes-12              5322.58      5288.80      0.99x
BenchmarkAsyncThroughputNetworkMultiple/5_Pair,_4096_Bytes-12              2343.50      2132.60      0.91x
BenchmarkAsyncThroughputNetworkMultiple/10_Pair,_4096_Bytes-12             749.65       766.44       1.02x
BenchmarkAsyncThroughputNetworkMultiple/Half_CPU_Pair,_4096_Bytes-12       1367.51      1295.00      0.95x
BenchmarkAsyncThroughputNetworkMultiple/CPU_Pair,_4096_Bytes-12            630.64       634.98       1.01x
BenchmarkAsyncThroughputNetworkMultiple/Double_CPU_Pair,_4096_Bytes-12     322.87       322.56       1.00x
BenchmarkThroughputClient/test-12                                          2178.65      2174.01      1.00x
BenchmarkThroughputResponseClient/test-12                                  2175.68      2161.26      0.99x
BenchmarkThroughputServerSingle/test-12                                    2166.22      2173.90      1.00x
BenchmarkThroughputServerUnlimited/test-12                                 872.78       869.12       1.00x
BenchmarkThroughputServerLimited/test-12                                   169.70       169.47       1.00x
BenchmarkThroughputResponseServerSingle/test-12                            2186.84      2184.22      1.00x
BenchmarkThroughputResponseServerSlowSingle/test-12                        5.94         5.91         0.99x
BenchmarkThroughputResponseServerSlowUnlimited/test-12                     1056.76      1136.29      1.08x
BenchmarkThroughputResponseServerSlowLimited/test-12                       387.69       393.55       1.02x
BenchmarkSyncThroughputPipe/32_Bytes-12                                    22.75        22.59        0.99x
BenchmarkSyncThroughputPipe/512_Bytes-12                                   381.78       360.37       0.94x
BenchmarkSyncThroughputPipe/1024_Bytes-12                                  719.97       720.67       1.00x
BenchmarkSyncThroughputPipe/2048_Bytes-12                                  1432.89      1434.11      1.00x
BenchmarkSyncThroughputPipe/4096_Bytes-12                                  2805.41      2801.64      1.00x
BenchmarkSyncThroughputNetwork/32_Bytes-12                                 8.70         8.79         1.01x
BenchmarkSyncThroughputNetwork/512_Bytes-12                                133.15       132.69       1.00x
BenchmarkSyncThroughputNetwork/1024_Bytes-12                               256.53       255.94       1.00x
BenchmarkSyncThroughputNetwork/2048_Bytes-12                               496.38       501.52       1.01x
BenchmarkSyncThroughputNetwork/4096_Bytes-12                               978.21       960.84       0.98x
BenchmarkAsyncThroughputLarge/1MB-12                                       16328.54     16623.89     1.02x
BenchmarkAsyncThroughputLarge/2MB-12                                       11954.94     11600.11     0.97x
BenchmarkAsyncThroughputLarge/4MB-12                                       12383.69     12454.12     1.01x
BenchmarkAsyncThroughputLarge/8MB-12                                       11818.17     12300.36     1.04x
BenchmarkAsyncThroughputLarge/16MB-12                                      11053.05     10849.48     0.98x
BenchmarkSyncThroughputLarge/1MB-12                                        10838.07     10893.64     1.01x
BenchmarkSyncThroughputLarge/2MB-12                                        11547.35     11221.87     0.97x
BenchmarkSyncThroughputLarge/4MB-12                                        12551.62     11111.79     0.89x
BenchmarkSyncThroughputLarge/8MB-12                                        12003.42     12230.95     1.02x
BenchmarkSyncThroughputLarge/16MB-12                                       10714.80     10394.64     0.97x
BenchmarkTCPThroughput/32_Bytes-12                                         70.01        67.38        0.96x
BenchmarkTCPThroughput/512_Bytes-12                                        637.40       638.50       1.00x
BenchmarkTCPThroughput/1024_Bytes-12                                       835.08       834.90       1.00x
BenchmarkTCPThroughput/2048_Bytes-12                                       945.79       949.92       1.00x
BenchmarkTCPThroughput/4096_Bytes-12                                       1037.09      1034.18      1.00x
BenchmarkTCPThroughput/1MB-12                                              11111.79     11312.43     1.02x
BenchmarkTCPThroughput/2MB-12                                              12107.58     11344.57     0.94x
BenchmarkTCPThroughput/4MB-12                                              12161.93     11444.58     0.94x
BenchmarkTCPThroughput/8MB-12                                              11599.21     11760.14     1.01x
BenchmarkTCPThroughput/16MB-12                                             10262.18     10286.48     1.00x

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have signed-off my commits with git commit -s (see the developer's certificate of origin)

@ShivanshVij ShivanshVij changed the title deps: Updating polyglot version to v1.2.1 deps: Updating polyglot version to v1.2.2 Mar 27, 2024
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij ShivanshVij merged commit e0e466c into staging Mar 27, 2024
5 checks passed
@ShivanshVij ShivanshVij deleted the shiv/update-deps branch March 27, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant