Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: C Bindings #30

Merged
merged 24 commits into from
Sep 15, 2023
Merged

Feat: C Bindings #30

merged 24 commits into from
Sep 15, 2023

Conversation

ShivanshVij
Copy link
Member

Description

This PR adds C and C++ support to Polyglot by reusing the Rust implementation with some custom C Bindings

Type of change

  • New feature (non-breaking change which adds functionality) [title: 'feat:']

Testing

All tests added to c_bindings/tests folder. They can be run with make clib_test.

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have signed-off my commits with git commit -s (see the developer's certificate of origin)

Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij ShivanshVij requested review from SuperManifolds and removed request for SuperManifolds September 13, 2023 22:04
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij ShivanshVij marked this pull request as ready for review September 14, 2023 23:40
decoder.rs Outdated Show resolved Hide resolved
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij ShivanshVij self-assigned this Sep 15, 2023
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
SuperManifolds
SuperManifolds previously approved these changes Sep 15, 2023
Copy link
Contributor

@SuperManifolds SuperManifolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🇨

Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij ShivanshVij merged commit f1fe289 into staging Sep 15, 2023
8 checks passed
@ShivanshVij ShivanshVij deleted the c-bindings branch September 15, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants