Custom SchemeRegistry for created HttpClient in AsyncHttpClient

[Diederikjh]

This project looks good, and it is very close to what we need in our project.

One thing that is a potential snag is the inability to set a custom SchemeRegistry when creating a new instance of AsyncHttpClient. (Our project must have a custom SocketFactory for https as our QA servers use self signed certificates.) Since the SchemeRegistry can't be set on a HttpClient after creating it, getting a reference to the HttpClient won't help either.

I would suggest adding another constructor to AsyncHttpClient that pass in a, say, HttpClientBuilder that has overridable methods for getting the SchemeRegistry, socketTimeout parameters etc? Then our project could create a specialised version of that class when we create a new AsyncHttpClient, that sets up the ConnectionManager with our desired SchemeRegistry.

[smarek]

There is now change, which allows you to set default ports for HTTP and HTTPS (thus first part of work with SchemeRegistry)

Also if you're getting certificate error, you can use constructor AsyncHttpClient(boolean) to not verify certificates (consequence of one bug fix)

But I'm letting this issue open, as I like the option to provide configured HttpClient/override SchemeRegistry if needed.