add option to set kafka's StartOffset on the consumer #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
force-pushed
the
kafkaStartOffset
branch
from
06842e6
to
8c5e91f
Compare
maxekman
approved these changes
Feb 9, 2022
|
Nice PR! I approved running on CI. Please rebase and take a look at the tests and we can merge it. |
|
the test is failing to connect to kafka, which of course I had kafka running locally when i tested so it worked. what's the best strategy here? remove the test? flag it as integration requiring kafka? other? |
|
Yeah, flag as integration. Look at the other integration tests for how. 👍 |
|
Thanks for the contribution! |
|
You're welcome. I appreciate the library 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes a new method
WithStartOffsetusing the Option on the EventBus allowing users to configure where to start the consumerAffected Components
Related Issues
#339
Solution and Design
I followed the pattern using the Option type similar to WithCodec
Steps to test and verify
How do you feel about the stretchr testify package? I can remove that for the test assertions if you'd prefer.