fix decoding null values that generate issue

loopline-systems · Feb 14, 2019 · b4f84d6 · b4f84d6
1 parent 1059856
commit b4f84d6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/LooplineSystems/CloseIoApiWrapper/CloseIoResponse.php b/src/LooplineSystems/CloseIoApiWrapper/CloseIoResponse.php
@@ -134,6 +134,12 @@ public function getHeaders(): array
      */
     private function decodeBody(): void
     {
+        if (empty($this->body) || $this->body === null) {
+            $this->decodedBody = [];
+
+            return;
+        }
+
         $this->decodedBody = json_decode($this->body, true);
 
         if (json_last_error() !== JSON_ERROR_NONE) {

diff --git a/tests/LooplineSystems/CloseIoApiWrapper/CloseIoResponseTest.php b/tests/LooplineSystems/CloseIoApiWrapper/CloseIoResponseTest.php
@@ -35,7 +35,7 @@ public function testGetters(): void
     /**
      * @dataProvider getDecodedBodyDataProvider
      */
-    public function testGetDecodedBody(string $body, array $expectedDecodedBody): void
+    public function testGetDecodedBody(?string $body, array $expectedDecodedBody): void
     {
         $response = new CloseIoResponse(new CloseIoRequest('GET', '/foo/'), 200, $body);
 
@@ -47,6 +47,8 @@ public function getDecodedBodyDataProvider(): array
         return [
             ['{"foo":"bar"}', ['foo' => 'bar']],
             ['false', []],
+            ['', []],
+            [null, []],
         ];
     }