Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

refs #41: phpstan level 3 #64

Merged
merged 1 commit into from
Apr 22, 2018
Merged

refs #41: phpstan level 3 #64

merged 1 commit into from
Apr 22, 2018

Conversation

mavimo
Copy link
Collaborator

@mavimo mavimo commented Apr 21, 2018

refs #41

To merge after #63

@mavimo mavimo added this to the v0.7.0 milestone Apr 21, 2018
@mavimo mavimo self-assigned this Apr 21, 2018
@mavimo mavimo requested a review from mickadoo April 21, 2018 18:42
@mavimo mavimo mentioned this pull request Apr 21, 2018
@coveralls
Copy link

coveralls commented Apr 21, 2018

Coverage Status

Coverage increased (+0.08%) to 22.97% when pulling 1531590 on feature/41-phpstan-level3 into 6834458 on feature/41-phpstan-level2.

Copy link
Collaborator

@mickadoo mickadoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a pity we have to type hint each API, both inside the method and in the docblock, but if there's no other way to pass this analysis it's not the worst thing in the world

@mavimo
Copy link
Collaborator Author

mavimo commented Apr 22, 2018

@mickadoo we can remove docblock annotation when we move to php7 and we type hint methods signature, since we keep support for php 5.6 in this release we should not use type hint in codebase and we need to use annotation.

@mavimo mavimo changed the base branch from feature/41-phpstan-level2 to develop April 22, 2018 12:33
@mavimo mavimo merged commit 560a4da into develop Apr 22, 2018
@mavimo mavimo deleted the feature/41-phpstan-level3 branch April 22, 2018 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants