Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new group for Creation Club plugins #73

Closed
wants to merge 0 commits into from
Closed

Conversation

Freso
Copy link
Member

@Freso Freso commented Jul 20, 2018

Functionally there should be no change to before, but this makes the masterlist slightly more readable since it removes the DLC group entries from all the CC after records.

It also makes is slightly more semantic, as Creation Club content now get identified on their own in the LOOT UI.

Making a PR instead of simply merging in right away to get some feedback. Please don't merge. I'll merge it when I feel there's enough of a consensus about it. :)

@Freso Freso requested review from MacSplody and Ortham July 20, 2018 23:58
@Freso
Copy link
Member Author

Freso commented Jul 21, 2018

I just noticed that DLCUltraHighResolution.esm was not listed in the CC afters before, but it will technically be now. I feel like this is more of an earlier oversight rather than a deliberate exclusion. If not, please let me know. :)

Oh, and @CptMcSplody, I requested review from you since it looks like you're the main person working on the SSE masterlist right now, and this seems like something that - if you agree with it - could be ported there as well.

@Ortham
Copy link
Member

Ortham commented Jul 21, 2018

As of v0.13.1, we don't actually need any load order metadata in the masterlist for CC plugins, so I'm more in favour of just removing them entirely (unless they've got other metadata). This would cause problems for users still on v0.13.0, but AFAIR they already can't sort their load orders because not all CC plugins are in the masterlist, so that might be irrelevant.

@Freso
Copy link
Member Author

Freso commented Jul 21, 2018

I can very quickly add all CC plugins to the masterlist and then possibly add a warning for LOOT <0.13.1 that going forward, they really need the newer LOOT if they're using Creation Club content?

@Ortham
Copy link
Member

Ortham commented Jul 21, 2018

I don't really mind either way. 🤷‍♂️ It's up to you.

@Freso
Copy link
Member Author

Freso commented Jul 21, 2018

Is there a way to check LOOT version in the masterlist currently, or was that removed when the LOOT version check message was moved into LOOT proper?

@Freso
Copy link
Member Author

Freso commented Jul 21, 2018

I'm not sure what LOOT equivalent version LOOT API MO2 and Vortex are currently using for their internal sort functions, but I think we should probably support whatever at least the very latest "stable"/released versions of those use, and maybe even one or two versions behind that too.

Anyway, I merged this for now. The output of that script I linked is already very(!!) verbose, so if it can have slightly less repetition by not repeating the DLC plugins, I think that's a boon.

@Freso Freso deleted the cccontent-group branch July 21, 2018 14:26
Freso added a commit to loot/skyrimse that referenced this pull request Jul 22, 2018
Functionally there should be no change to before, but this makes
the masterlist slightly more readable since it removes DLC group
entries from all the CC `after` records.

It also makes is slightly more semantic, as Creation Club content now
get identified on their own in the LOOT UI.

See also loot/fallout4#73
MacSplody pushed a commit to loot/skyrimse that referenced this pull request Jul 23, 2018
* Make new group for Creation Club plugins

Functionally there should be no change to before, but this makes
the masterlist slightly more readable since it removes DLC group
entries from all the CC `after` records.

It also makes is slightly more semantic, as Creation Club content now
get identified on their own in the LOOT UI.

See also loot/fallout4#73

* Add warning for LOOT <0.13.1 with Creation Club plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants