Add a convenience steam sign in method that integrates the subsystem #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlmightyMikkel
approved these changes
Apr 8, 2024
TobiasBerg
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative change. Now that I understand the Online Subsystems better after spending considerable time with them (I blame Google), I felt when updating the Steam sign in docs like we could simplify this greatly for our users to actually less cost to us than one'd think.
I have yet to test whether this actually works. Especially in different editor versions.
Additionally, Epic has said that the Online Subsystems are out of support (willl be replaced).
All of this maintenance would fall on us with this change. That said, Steam is a good POC for such a change since it's so simple.
Let's have a chat about it.