This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
Feedback from HN discussion on Punchtop Blog Post #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger requires an attribute to enable
This fixes one of my frustrations that subsequent runs of cargo clippy are no-ops. https://news.ycombinator.com/item?id=19204577
RUST_LOG is for first party tools. Read log filters from a punchtop-specific env var https://news.ycombinator.com/item?id=19205602
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I blogged about my experience learning rust by building punchtop.
A subthread of the HN discussion offered some good code review feedback addressing some of my frustrations. This PR applies what I learned.
Thank you @Arnavion!