Properly do type punning on float endian conversion functions

This only showed up with optimizations enabled.
lopter · Aug 9, 2015 · ade73dc · ade73dc
1 parent 4e73596
commit ade73dc
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lifx/wire_proto.h b/lifx/wire_proto.h
@@ -28,15 +28,17 @@ typedef float    floatle_t;
 static inline floatle_t
 lgtd_lifx_wire_htolefloat(float f)
 {
-    *(uint32_t *)&f = htole32(*(uint32_t *)&f);
-    return f;
+    union { float f; uint32_t i; } u  = { .f = f };
+    htole32(u.i);
+    return u.f;
 }
 
 static inline floatle_t
 lgtd_lifx_wire_lefloattoh(float f)
 {
-    *(uint32_t *)&f = le32toh(*(uint32_t *)&f);
-    return f;
+    union { float f; uint32_t i; } u  = { .f = f };
+    le32toh(u.i);
+    return u.f;
 }
 
 enum { LGTD_LIFX_PROTOCOL_PORT = 56700 };