Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1267

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update dependencies #1267

wants to merge 2 commits into from

Conversation

vitalyster
Copy link
Contributor

@nfsprodriver
Copy link
Member

Sorry, this doesn't work for me in all LTS versions. Anyone else can test it?

@vitalyster
Copy link
Contributor Author

Which error you have?

@vitalyster
Copy link
Contributor Author

I did add Travis CI configuration and everything works with node 11, 10 and 8 - https://travis-ci.org/vitalyster/im/builds/476013924
Do you really need Node < 8 support?

@nfsprodriver
Copy link
Member

Well, it's not directly an error, but some problems with vulnerabilities (4 high), same as in tarvis log.

@nfsprodriver
Copy link
Member

There's also a problem with the Renderer. A built app doesn't start on UT, because the Renderes class in blaze.js is missing.

@vitalyster vitalyster changed the title Update to latest grunt-sass Update dependencies Jan 6, 2019
@vitalyster
Copy link
Contributor Author

Vulnerable packages are dependencies of grunt-nw-builder, grunt-debian-package, etc, these packages does not look maintained but they are only devDependencies so vulnerable 'minimatch' package should not be ship with app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vitalyster @nfsprodriver