Fix for bad position nn60.00, and nicer DAO computation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 6, 2021 23:56
In the special case of minute of position > 59.9990 the result is 60.0. This results in a wrong APRS position location (i.e. 53.60.00N). This patch also makes create_dao_aprs() nicer and fixes "TODO: optimize ugly float to char to string to int conversion?". I tested the patch, and the author of the dao_aprs extension, dj1an, has confirmed everythin is still ok.
|
Another fix for a different par: |
if ? ... : ... syntax is efficient and nerdy, but not everyone likes it, and I admit, it's better readable ;)
|
Modification for code readers. |
|
close pull request did not what I expected ;) |
|
@dl9sau Thank you very much for your changes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sprintf("%f", ... rounds up.
In the special case of minute of position > 59.9990 the result is 60.0.
This results in a wrong APRS position location (i.e. 53.60.00N).
This patch also makes create_dao_aprs() nicer and fixes "TODO: optimize ugly float to char to string to int conversion?".
I tested the patch, and the author of the dao_aprs extension, dj1an, has confirmed everythin is still ok.