-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test and enable GitHub Actions (CI) #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also on the OSDC course and am trying out reviewing the change.
Clearly there could be much more, but at least it's a start. We could extend to use different OS's and perl versions.
thanks for the contribution, a bit of CI to automate testing would be helpful! I'll look at getting some of this integrated, will see if we can get this merged with a new branch on my repo |
Why on a branch? The idea of CI is to run on the code as you develop it. |
@szabgab Fair point. I was thinking I could improve it by dumping it to a temp directory using But this gives me a good start so I'll merge it to master now. |
Thanks for accepting. In general you'd want to make the tests as simple as possible so they won't add extra complexity. One would also need to fix the test environment to make sure the images are generated the same way and exclude the images in cases where they might be different due to different versions of libgd. |
The test uses the default example and the default configuration and compares the results to an earlier set of output.
There is a lot to improve on the tests.
Was created during a session of OSDC