-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for tickets #30, #39 and #40 #42
Conversation
…n the dropdown is opened. fixes lordfriend#40
…n the dropdown is opened. fixes lordfriend#40
…/nya-bootstrap-select into feature/focus-on-selected-element Conflicts: dist/js/nya-bs-select.min.js
if an item is selected previously, focus will be set on that item when t...
Sorry for response so late, Because I don't have a computer to review code right now. I will review this two days later. |
I've reviewed these commits. Thank you for contributing! User can't unselect a option when in single selection mode isn't a bug when I started writing this project. It is intentionally designed to make it look like a native select element.(browser native select element don't allow you to unselect in single selection mode). But After release this project I found it is very hard to restrict this and didn't document about this feature. So many user complain that it is a bug. So I think allowing unselect option in single selection mode should be a feature as you expected. |
Thank you very much to take the time to read this @lordfriend. If you have any suggestion in order we could also fix issue #43 we would happily try to solve it. |
No description provided.