Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for tickets #30, #39 and #40 #42

Merged
merged 13 commits into from
Mar 1, 2015
Merged

Conversation

jca258
Copy link
Contributor

@jca258 jca258 commented Feb 22, 2015

No description provided.

@jca258 jca258 changed the title Fix 0 value element selection Fixes for tickets #30, #39 and #40 Feb 22, 2015
@lordfriend
Copy link
Owner

Sorry for response so late, Because I don't have a computer to review code right now. I will review this two days later.

lordfriend added a commit that referenced this pull request Mar 1, 2015
@lordfriend lordfriend merged commit 8148477 into lordfriend:master Mar 1, 2015
@lordfriend
Copy link
Owner

I've reviewed these commits. Thank you for contributing!

User can't unselect a option when in single selection mode isn't a bug when I started writing this project. It is intentionally designed to make it look like a native select element.(browser native select element don't allow you to unselect in single selection mode).

But After release this project I found it is very hard to restrict this and didn't document about this feature. So many user complain that it is a bug. So I think allowing unselect option in single selection mode should be a feature as you expected.

@ricardocasares
Copy link
Contributor

Thank you very much to take the time to read this @lordfriend. If you have any suggestion in order we could also fix issue #43 we would happily try to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants