Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow assigning attributes on Rect class #32

Closed
lordmauve opened this issue Aug 3, 2015 · 1 comment
Closed

Disallow assigning attributes on Rect class #32

lordmauve opened this issue Aug 3, 2015 · 1 comment
Labels
bug Something isn't working major

Comments

@lordmauve
Copy link
Owner

Originally reported by: Daniel Pope (Bitbucket: lordmauve, GitHub: lordmauve)


Issue #11 "Cannot assign attributes on Rect object" was a bad idea.

I immediately hit a case where someone (@tjg) had written bat.centrex instead of bat.centerx - and this fails silently once again.

Now we have a spellchecker we could spellcheck this and fail with an appropriate error.

There's also a concern about incompatibility with Pygame itself - if users have been used to assigning attributes to Rect objects, it may cause confusion when using Rect objects from Pygame itself which do not allow this.


@lordmauve
Copy link
Owner Author

Original comment by Daniel Pope (Bitbucket: lordmauve, GitHub: lordmauve):


Disallow setting attributes on Rect; enrich corresponding AttributeError with spellcheck suggestions (closes #32)

@lordmauve lordmauve added major bug Something isn't working labels Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant