update screen.py so we can draw custom images with any pensize or width #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update class SurfacePainter in screen.py ensure user can draw circle with custom pensize
lordmauve
added
the
blocked
|
Due to broken implementation in Pygame <=1.9.3 (#68), this is blocked at least until Pygame 1.9.4 is released. |
Repository owner
deleted a comment from
yonghuming
May 18, 2018
|
Pygame 1.9.4 is now released. We could merge this if we ensure we depend on Pygame 1.9.4 or higher. |
|
#217 does more or less the same. If the parameter name 'pensize' is better. Let me know. |
|
Pygame Zero should align with Pygame on terminology. The |
|
Fixed in d42e3e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i use pensize not width because maybe python beginner have learned python turtle and it use pensize to refer width also in Scratch.
pensize may easier to understand for pupils.