Set value by keyboard #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved setValue to input's onChange from the label's onClick. This allows the user to set the value with either their keyboard or with their mouse.
|
Nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Moved setValue to input's onChange from the label's onClick. This allows the user to set the value with either their keyboard or with their mouse.
Why?
Using the keyboard arrow keys appears to change the selection, but the setValue function is not invoked.
Checklist
Closes [Bug] Value should be able to be set by keyboard #80
How was this tested:
Interacted with the component in storybook.
No.