FIX correct functional as labels in plot_reliability_diagram #125
Conversation
m-maggi
changed the title
functional and levelfunctional and level
| @@ -177,7 +178,7 @@ | |||
| "│ str ┆ f64 ┆ u32 ┆ f64 ┆ f64 ┆ f64 │\n", | |||
| "╞══════════════════╪═══════════╪════════════╪══════════════╪═════════════╪══════════╡\n", | |||
| "│ linear_quant_reg ┆ 0.005 ┆ 200 ┆ 200.0 ┆ 0.030488 ┆ 0.869899 │\n", | |||
| "│ hgbt_quant_reg ┆ 0.0 ┆ 200 ┆ 200.0 ┆ 0.030695 ┆ 1.0 │\n", | |||
| "│ hgbt_quant_reg ┆ -0.025 ┆ 200 ┆ 200.0 ┆ 0.031653 ┆ 0.43057 │\n", | |||
There was a problem hiding this comment.
I'm suprised to see a model change here. Maybe we should fix the random_state parameter of HGBT to some integer.
There was a problem hiding this comment.
@lorentzenchr thanks for spotting this. I looked at the random_state parameter and it seems to me that due to the small sample size the early stopping is disabled, hence it should not have an impact on the results.
I just tried to change environment and re-run the notebook with the code as of 0113d5a and got results almost identical to the version in the main branch (the table to which your comment refers to is exactly the same).
There was a problem hiding this comment.
As info: As written in the development doc, you can run hatch run jupyter:lab. This will create a virtual environment with all you need to run the notebooks, and run jupyter lab.
lorentzenchr
changed the title
functional and level
|
@m-maggi Thanks for the fix. |
Fixes #124