Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and tests for get() and has() to explicitly handle missing input. #185

Merged
merged 6 commits into from
Dec 9, 2014

Conversation

markstos
Copy link
Collaborator

@markstos markstos commented Dec 9, 2014

Usually get() and has() are called with explicit inputs, but they can also be
called with a variable name, and that variable can unexpectly undefined or null,
as @robludwig found and submitted a patch for.

This pull request builds on his work by adding test coverage and also covering has()
as well as get().

@lorenwest: Note that for has() I have the code return false on missing input
instead of throwing an exception like get() does.

The value of has() is that it works differently that get() does, precisely so people
can avoid a try/catch block around get().

Since has() is largely for avoiding try/catch, it made sense to have it avoid
throwing exceptions.

@lorenwest
Copy link
Collaborator

This looks great - thanks for the tests!

lorenwest added a commit that referenced this pull request Dec 9, 2014
Code and tests for get() and has() to explicitly handle missing input.
@lorenwest lorenwest merged commit 982027a into node-config:master Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants