Code and tests for get() and has() to explicitly handle missing input. #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually get() and has() are called with explicit inputs, but they can also be
called with a variable name, and that variable can unexpectly undefined or null,
as @robludwig found and submitted a patch for.
This pull request builds on his work by adding test coverage and also covering has()
as well as get().
@lorenwest: Note that for has() I have the code return false on missing input
instead of throwing an exception like get() does.
The value of
has()
is that it works differently that get() does, precisely so peoplecan avoid a try/catch block around get().
Since
has()
is largely for avoiding try/catch, it made sense to have it avoidthrowing exceptions.