-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNA-RNA hybrid model #68
Conversation
Interaction type with modified backbone potential for relaxing systems containing both DNA and RNA.
…dna-rna-hybrids into double-inheritance
Adding the new topology format to the hybrid model
Trying to fix (suspected) undefined behaviour
Version of hybrid model which uses inheritance
Excited to see this update! It looks like you've got a bunch of test files in |
Sure, just did it!
…On Wed, Sep 20, 2023 at 9:58 AM Erik Poppleton ***@***.***> wrote:
Excited to see this update! It looks like you've got a bunch of test files
in analysis/test. There is a script in there called cleanup.sh which will
remove all the generated files to clean up the commit. Can you please run
that to remove the files?
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASQGARMUY7Z6MRCIPYXEVVDX3KV3BANCNFSM6AAAAAA46PSWKU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks for the PR, this will be a great addition to the code! I'm trying to make sense of the changes so that I can make sure that we are not going to break anything. In the meantime, can you resolve |
Sorry for the multiple messages. The other issue I see is that you are trying to merge with |
We also need to merge oat_dev into new_topology first since I also rewrote convert.py and the oat data structures/readers to work with the new topology. |
Erik and I are working on the new topology branch. We plan to merge it later this week and then I'll start working on this one. However, since there are some core files that are involved, I think it would be better if we could merge your code into a non-master branch. I don't know if you can change that after you created the PR or you have to make a new one. If you can't edit this one then I'll close it and you can make a new one. |
Looks like this can be easily done - I've now changed the base branch of
the PR to the new topology one.
…On Mon, Sep 25, 2023 at 12:21 PM Lorenzo Rovigatti ***@***.***> wrote:
Erik and I are working on the new topology branch. We plan to merge it
later this week and then I'll start working on this one. However, since
there are some core files that are involved, I think it would be better if
we could merge your code into a non-master branch. I don't know if you can
change that after you created the PR or you have to make a new one. If you
can't edit this one then I'll close it and you can make a new one.
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASQGARNCC34I24S33CH45BLX4FSJXANCNFSM6AAAAAA46PSWKU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks! I have created a new branch ( |
@eryykr thanks again for the PR! I have merged it into a separate branch and will work on merging it to master as soon as I'm done with |
No description provided.