-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecurityEventNotification.req #262
Comments
We had the same issue with ABB, so we modified the library to support OCPP 1.6j security extension, but it does not include unit tests. We tested it in production and so far, it worked fine (https://github.com/GLCharge/ocpp-go) |
@xBlaz3kx would you like creating a PR for the security extension? It's been on my ToDo list but didn't get to it yet. Happy to include it and then write some tests for it. |
@lorenzodonini Sure, I can do that. The only thing I'm a bit unsure of is the way I implemented/added additional handlers for incoming messages, specified in the extension. The extension's specification doesn't really mention if the functionalities should be split into different profiles (like in the original specification), nor does it specify any additional So I did this: // OCPP 1.6j Security extension
chargePoint.SetCertificateHandler(handler)
chargePoint.SetLogHandler(handler)
chargePoint.SetSecureFirmwareHandler(handler)
chargePoint.SetExtendedTriggerMessageHandler(handler)
chargePoint.SetSecurityHandler(handler) I'd like to hear your thoughts regarding the implementation approach. |
@xBlaz3kx thanks a lot for opening the PR. I'll have a detailed look in the next few days. Regarding the structure, since the security extension is backported from v2, it's technically up to us where we want to put it.
Just FYI the structuring is derived from the functional blocks as presented in the 2.0.1 specs, which are identified by letters If we follow this split I would recommend leveraging at least the existing Your point about the |
@lorenzodonini Of course, no problem. I'll have to fix a couple of details (I've renamed the module because we're using it in our product) before it can be merged. Regarding the structure - it is essentially what I've done, with minor naming differences, so I think we are mostly aligned. Take a look when you can, and let me know if I should fix anything 😄 |
Couldn't comment directly on your fork, but I noticed that the types.CertificateUse enum for
|
Thanks for catching this! What I've done is copy most of the code from the 2.0.1 implementation/folder, as the functionality and naming conventions very closely match the ones defined in the security extension, so I guess I need to double check. |
Hey @atschabu, thanks! Unfortunately I don't work for the company anymore, so I can't do much about the PR. Instead, you can make a PR against my repository, and I'll merge the fixes. |
Hey @xBlaz3kx, tried to create a PR to include @atschabu changes into your fork to speed up things, but I noticed that your fork is not quite a mirror of (GLCharge/ocpp-go) I can't find the charge center
And I can't find the charge point
|
Hey @AhmedAbouelkher, correct, its not a direct mirror of the repository. I've implemented the changes in a separate branch, not in the main. |
That's great. I can confirm that this is indeed the branch that I cloned and did not find these missing functions. |
Hey @AhmedAbouelkher, I 'm not sure how, but I guess I forgot to transfer (copy) the newly added interface methods. I'm working on the fix(es) now. |
https://aftersales.alfen.com/servicedesk/customershim/secure/attachment/1024186/1024186_OCPP+1.6+security+whitepaper+edition+3.pdf?fromIssue=390054
Seems that ocpp1.6 does not handle
SecurityEventNotification
. Is it planned to integrate this? Issue here is with Alfen stations that keep sendingSecurityEventNotification
and stack does not respond.The text was updated successfully, but these errors were encountered: