Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Outlinedbutton and Button in SettingsActivity.kt #33

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Added Outlinedbutton and Button in SettingsActivity.kt #33

merged 1 commit into from
Jun 8, 2023

Conversation

bhavesh100
Copy link
Contributor

Added Outlinedbutton and Button in SettingsActivity.kt

I added two variables

  1. darkThemeBtnTxt - It contains a list of "Dark", "System", "Light"
  2. curSelectedThemeTxt - It contains current selected theme which is default by "System"

Added heading which is "Theme" instead of "Dark theme"

Leaving the dark theme switch as it is so you can check how the Outlined Button and Button are working

@bhavesh100
Copy link
Contributor Author

Or any suggestion you want to give

@lorenzovngl lorenzovngl mentioned this pull request Jun 8, 2023
Closed
lorenzovngl
lorenzovngl approved these changes Jun 8, 2023
View reviewed changes
Copy link
Owner

@lorenzovngl lorenzovngl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thank you! I will add the code to store the user choice.

@lorenzovngl lorenzovngl merged commit b555985 into lorenzovngl:custom-dark-mode-and-dynamic-colors Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzovngl lorenzovngl lorenzovngl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhavesh100 @lorenzovngl