Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedup roxygen2 hook by checking if it has to run at all #145

Closed
lorenzwalthert opened this issue Apr 9, 2020 · 2 comments · Fixed by #151
Closed

speedup roxygen2 hook by checking if it has to run at all #145

lorenzwalthert opened this issue Apr 9, 2020 · 2 comments · Fixed by #151

Comments

@lorenzwalthert
Copy link
Owner

use git diff via {git2r} and check if diff includes roxygen comment at all.
@krzyslom
Copy link
Contributor

This will also solve the problem with roxygenize hook running on files that are not even tracked yet.

@lorenzwalthert
Copy link
Owner Author

lorenzwalthert commented Apr 12, 2020 via email

@lorenzwalthert lorenzwalthert mentioned this issue Apr 12, 2020
Merged
lorenzwalthert added a commit that referenced this issue Apr 12, 2020
@lorenzwalthert
Merge pull request #151 from lorenzwalthert/issue-145
c679a1d 
- a void unnecessary calls to roxygen2::roxygenize() (#145).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid unnecessary calls to roxygen2::roxygenize() lorenzwalthert/precommit
2 participants
@lorenzwalthert @krzyslom