Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CRAN submission required because of pinned python versions #200

Closed
lorenzwalthert opened this issue Oct 3, 2020 · 0 comments · Fixed by #207
Closed

New CRAN submission required because of pinned python versions #200

lorenzwalthert opened this issue Oct 3, 2020 · 0 comments · Fixed by #207
Labels
Complexity: Medium Priority: Critical Status: WIP Type: Infrastructure

Comments

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Oct 3, 2020 •
edited

CRAN checks are failing. There is no functional deficit, it's just that I set my self a reminder to switch to Python3 tests and installation methods for pre-commit conda. This happened in #191. To be fixed until 2020-10-15 .

https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/precommit-00check.html

We'll stick to the release process outlined in help(precommit:::release_gh). I.e. we'll do a first GitHub release with precommit:::release_gh(), ask users to precommit::autoupdate() and test it. Then, do a CRAN release process with precommit:::release_gh(is_cran = TRUE). To follow sem versioning, we'll wait with merging #203 into master.
@lorenzwalthert lorenzwalthert changed the title new CRAN submission because of pinned python versions New CRAN submission required because of pinned python versions Oct 3, 2020
lorenzwalthert added a commit that referenced this issue Oct 3, 2020
@lorenzwalthert
This reverts #183 for a better API to be implementented at a later st…
80dd8ee 
…age, as outlined in #195.

For now, we focus on reverting #183 since we have a CRAN hotfix to do (#200).
lorenzwalthert added a commit that referenced this issue Oct 3, 2020
@lorenzwalthert
Merge pull request #201 from lorenzwalthert/issue-200
03b5043 
- Drop assumption test fixed in #191 (#200).
lorenzwalthert added a commit that referenced this issue Oct 3, 2020
@lorenzwalthert
This reverts #183 for a better API to be implementented at a later st…
3fdc825 
…age, as outlined in #195.

For now, we focus on reverting #183 since we have a CRAN hotfix to do (#200).
@lorenzwalthert lorenzwalthert mentioned this issue Oct 3, 2020
Merged
@lorenzwalthert lorenzwalthert mentioned this issue Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Medium Priority: Critical Status: WIP Type: Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v0.1.3 lorenzwalthert/precommit
1 participant
@lorenzwalthert