Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't presume pre-commit-config exists in ensure_renv_compat #413

Merged
merged 5 commits into from
May 31, 2022

Conversation

mpadge
Copy link
Contributor

@mpadge mpadge commented May 31, 2022

@lorenzwalthert Easy to reproduce the 馃悰 behind this one:

  1. Go to a directory anywhere that is not an R package and/or does not have a pre-commit-config.yaml file
  2. Start R
  3. type library(precommit) and watch it error

Another question for you here, before i open a hopefully unnecessary issue: I have entirely broken precommit (this package, not the python one) by manually removing all cached renv directories, and removing ~/.cache/R/R.cache. precommit now fails to find any renv-ed versions of desc, styler, docopt, whatever. I've tried removing and reinstalling everything, but no matter what I do precommit fails to reestablish its renv. Any quick tips? Or shall i open an issue?

@lorenzwalthert
Copy link
Owner

Great, thanks for the contribution.

@lorenzwalthert
Copy link
Owner

Can you add a news bullet according to tidyverse style?

@lorenzwalthert
Copy link
Owner

As per the other problem: This is probably a pre-commit issue. Can you run $ pre-commit clean to clean the pre-commit cache?

@mpadge
Copy link
Contributor Author

mpadge commented May 31, 2022

As per the other problem: This is probably a pre-commit issue. Can you run $ pre-commit clean to clean the pre-commit cache?

Yep, that did it. Thanks! I've added news item too

@lorenzwalthert lorenzwalthert merged commit 5466ad5 into lorenzwalthert:main May 31, 2022
@lorenzwalthert
Copy link
Owner

Thanks @mpadge 馃コ

lorenzwalthert added a commit that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants